Skip to content

Make sure that tp_as_xxx methods are never NULL in PyType_Ready() #157499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vstinner wants to merge 2 commits into from
Closed

Make sure that tp_as_xxx methods are never NULL in PyType_Ready() #157499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1bbdc4
Make sure that tp_as_xxx methods are never NULL in PyType_Ready()
vstinner Sep 14, 2026
11e34f2
Run make regen-all
vstinner Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Include/internal/pycore_abstract.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ extern "C" {
static inline int
_PyIndex_Check(PyObject *obj)
{
PyNumberMethods *tp_as_number = Py_TYPE(obj)->tp_as_number;
return (tp_as_number != NULL && tp_as_number->nb_index != NULL);
return (Py_TYPE(obj)->tp_as_number->nb_index != NULL);
}

// Exported for external JIT support
Expand Down
52 changes: 0 additions & 52 deletions Include/internal/pycore_slots_generated.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Modules/_bisectmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@ get_sq_item(PyObject *s)
// The parts of PySequence_GetItem that we only need to do once
PyTypeObject *tp = Py_TYPE(s);
PySequenceMethods *m = tp->tp_as_sequence;
if (m && m->sq_item) {
if (m->sq_item) {
return m->sq_item;
}
const char *msg;
if (tp->tp_as_mapping && tp->tp_as_mapping->mp_subscript) {
if (tp->tp_as_mapping->mp_subscript) {
msg = "%.200s is not a sequence";
}
else {
Expand Down
18 changes: 2 additions & 16 deletions Modules/_testinternalcapi/test_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading