Skip to content

gh-128509: Add tests on sys._is_immortal() - #157376

Open
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:is_immortal
Open

gh-128509: Add tests on sys._is_immortal()#157376
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:is_immortal

Conversation

@vstinner

@vstinner vstinner commented Sep 12, 2026

Copy link
Copy Markdown
Member

@vstinner vstinner added needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Sep 12, 2026
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Sep 12, 2026
@vstinner

Copy link
Copy Markdown
Member Author

@ZeroIntensity: As the sys._is_immortal() author, would you mind to review my tests please?

Comment thread Lib/test/test_sys.py
Comment on lines +1388 to +1389
self.assertTrue(is_immortal(b'x'))
self.assertTrue(is_immortal('x'))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem to be failing on the Ubuntu CI. I'm not too sure why. The rest of the PR looks good to me otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants