gh-156347: Fix the documentation of curses window.encoding - #156352
Closed
fedonman wants to merge 1 commit into
Closed
gh-156347: Fix the documentation of curses window.encoding#156352fedonman wants to merge 1 commit into
window.encoding#156352fedonman wants to merge 1 commit into
Conversation
The attribute is not used to encode str arguments on a build linked against a wide-character version of the curses library, which is the default: str is passed to curses as wide characters and the encoding of the current locale determines the bytes. It is used on a narrow build, where it also decodes results.
Documentation build overview
|
Member
|
Thank you for your report and PR. I merged more complete #156354 which fixes also other issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reword the two places that describe
window.encodingas encodingstrarguments. On a wide build it is not used for that, so the HOWTO now names the encoding of the current locale, and the attribute's own entry scopes the claim to a narrow build and covers results as well as arguments.Documentation only, so no NEWS fragment.
window.encodingdoes not encodestrarguments on a wide build #156347