Skip to content

gh-154727: Document that SSLSocket.version() comes from the TLS library - #154785

Open
mimi89999 wants to merge 2 commits into
python:mainfrom
mimi89999:ssl-docs
Open

gh-154727: Document that SSLSocket.version() comes from the TLS library#154785
mimi89999 wants to merge 2 commits into
python:mainfrom
mimi89999:ssl-docs

Conversation

@mimi89999

@mimi89999 mimi89999 commented Jul 27, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown

@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Jul 27, 2026
@python-cla-bot

python-cla-bot Bot commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Jul 27, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jul 27, 2026
Open
@read-the-docs-community

read-the-docs-community Bot commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #35526257 | 📁 Comparing 743dcc9 against main (85c8bce)

  🔍 Preview build  

431 files changed · + 10 added · ± 421 modified

+ Added

± Modified

picnixz
picnixz reviewed Jul 28, 2026
View reviewed changes
Comment thread Doc/library/ssl.rst Resolved
Comment thread Doc/library/ssl.rst Resolved
@mimi89999
mimi89999 requested a review from picnixz July 28, 2026 14:14
@mimi89999

mimi89999 commented Jul 28, 2026

Copy link
Copy Markdown
Author

@picnixz I changed the docstring based on #154727 (comment). I'm not fully happy with the wording, but I think that the description is accurate now.

@mimi89999 mimi89999 changed the title gh-154727: List TLSv1.3 among SSLSocket.version() return values gh-154727: Document that SSLSocket.version() comes from the TLS library Jul 30, 2026
@github-actions

github-actions Bot commented Oct 29, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Oct 29, 2026
@mimi89999

mimi89999 commented Oct 30, 2026

Copy link
Copy Markdown
Author

@picnixz I think that this is a useful change

picnixz
picnixz approved these changes Oct 30, 2026
View reviewed changes

@picnixz picnixz left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessary "useful" as the docs are sill correct as is ("possible return values include [...]" is deliberately vague and just shows examples of what you could find). But I don't think it's really important to show such examples.

@picnixz picnixz added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes and removed stale Stale PR or inactive for long period of time. labels Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees

No one assigned

Labels

awaiting merge docs Documentation in the Doc dir needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes skip news

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mimi89999 @picnixz