gh-154136: Define _ISOC23_SOURCE to fix building the math module on FreeBSD#154138
Merged
Conversation
…e on FreeBSD Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
serhiy-storchaka
requested review from
AA-Turner,
corona10,
emmatyping,
erlend-aasland and
itamaro
as code owners
July 19, 2026 14:00
skirpichev
approved these changes
Jul 20, 2026
skirpichev
left a comment
skirpichev
left a comment
Member
There was a problem hiding this comment.
I assume, that platforms libm is "good enough" (i.e. to pass our tests).
Probably we could replace AC_CHECK_FUNCS* with a different check, but current solution looks sufficiently safe for me.
Member
Author
|
Claude first proposed to replace AC_CHECK_FUNCS* with a different check, but this would left FreeBSD using the fallback implementation, even if they are available in the libm. I chose different minimal solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On FreeBSD, libm provides
cospi,sinpiandtanpi, butmath.hdeclares them only for C23, and defining_POSIX_C_SOURCEand_XOPEN_SOURCEreduces header visibility to C11. The link-onlyAC_CHECK_FUNCStest still finds the symbols, so compilingModules/mathmodule.cfailed.Defining
_ISOC23_SOURCEmakes the declarations visible, so the native libm implementations are detected and used. On other platforms it is a no-op.🤖 Generated with Claude Code