Skip to content

gh-153803: Raise ResponseError for a malformed struct in xmlrpc.client #153805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tonghuaroot wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −0
Open

gh-153803: Raise ResponseError for a malformed struct in xmlrpc.client #153805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7bb2fb
gh-153803: Raise ResponseError for a malformed struct in xmlrpc.client
tonghuaroot Jul 16, 2026
9694cbd
Fix NEWS cross-reference for ResponseError
tonghuaroot Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Lib/test/test_xmlrpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,13 @@ def test_loads_unsupported(self):
'</struct></value></param></params>')
self.assertRaises(ResponseError, xmlrpclib.loads, data)

def test_loads_malformed_struct(self):
ResponseError = xmlrpclib.ResponseError
data = ('<params><param><value><struct>'
'<member><name>k</name></member>'
'</struct></value></param></params>')
self.assertRaises(ResponseError, xmlrpclib.loads, data)

def check_loads(self, s, value, **kwargs):
dump = '<params><param><value>%s</value></param></params>' % s
result, m = xmlrpclib.loads(dump, **kwargs)
Expand Down
2 changes: 2 additions & 0 deletions Lib/xmlrpc/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,6 +756,8 @@ def end_struct(self, data):
# map structs to Python dictionaries
dict = {}
items = self._stack[mark:]
if len(items) % 2:
raise ResponseError()
for i in range(0, len(items), 2):
dict[items[i]] = items[i+1]
self._stack[mark:] = [dict]
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2026-07-16-12-00-00.gh-issue-153803.YbLNRy.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix :func:`xmlrpc.client.loads` raising :exc:`IndexError` instead of
``ResponseError`` for a malformed ``<struct>``. Patch by tonghuaroot.
Loading