gh-153792: Fix urllib.request digest auth crash on a malformed challenge#153793
Open
tonghuaroot wants to merge 1 commit into
Open
gh-153792: Fix urllib.request digest auth crash on a malformed challenge#153793tonghuaroot wants to merge 1 commit into
tonghuaroot wants to merge 1 commit into
Conversation
…challenge AbstractDigestAuthHandler.retry_http_digest_auth parsed a server-controlled WWW-Authenticate digest challenge without guarding the parse, so a malformed challenge raised a bare ValueError or IndexError out of urlopen(). Catch those around the two parse statements and decline (return None), as the handler already does for a 40x it cannot handle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A malformed server-controlled
WWW-Authenticate: Digestchallenge madeHTTPDigestAuthHandlerraise a bareValueErrororIndexErrorout ofurlopen(). Guard the two parse statements inretry_http_digest_authand decline (returnNone) a challenge that cannot be parsed, as the handler already does for a 40x it cannot handle.get_authorizationstays outside the guard so a real bug there is not masked.