-
-
Notifications
You must be signed in to change notification settings - Fork 34.9k
gh-153785: Generate AttributeError messages from context
#153786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
johnslavik
wants to merge
20
commits into
python:main
Choose a base branch
from
johnslavik:gh-153785
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+88
−1
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
ac555bc
Implement `AttributeError_str()`
johnslavik 4f22a16
Add tests
johnslavik b30d676
Check name too
johnslavik 28e04d3
Add docs
johnslavik e5c4922
Add news entry
johnslavik 3854563
Improve formatting
johnslavik 1e88331
Simplify?
johnslavik 2fd216a
Cooler formatting of the news entry
johnslavik 356f56e
Test custom messages aren't overwritten
johnslavik 8db0394
Fix news problem
johnslavik ebcc795
Shorter test name
johnslavik b6fda10
Fix inconsistent style
johnslavik d624835
Make thread-safe, presumably
johnslavik c50a356
Rarest case goes last
johnslavik 7ad5204
} else {
johnslavik b65a7fd
Remove unnecessary whitespace
johnslavik e99d875
Fix style
johnslavik 8c29de3
Avoid nesting critical sections!
johnslavik 6faf358
Fix error handling, crete strong refs for interpolation
johnslavik 086a0c9
Multiline if properly done
johnslavik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
Misc/NEWS.d/next/Core_and_Builtins/2026-07-16-02-50-01.gh-issue-153785.fJqPKC.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| The default error message is now generated from ``name`` and ``obj`` attributes | ||
| of :exc:`AttributeError` when both are set and the exception was constructed with | ||
| no positional arguments, or with a single positional argument equal to ``name``. | ||
| Patch by Bartosz Sławecki. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth a comment here that BaseException_str also locks and that's why this is outside of the lock.