Fix issues reported by cpython-review-toolkit in faulthandler#151341
Open
vstinner wants to merge 1 commit into
Open
Fix issues reported by cpython-review-toolkit in faulthandler#151341vstinner wants to merge 1 commit into
vstinner wants to merge 1 commit into
Conversation
vstinner
commented
Jun 11, 2026
vstinner
commented
Member
- snprintf() is not async-signal-safe: replace it with _Py_DumpDecimal().
- Fix tid type from 'long' to 'unsigned long'.
- Replace PyLong_AsLong() with PyLong_AsInt().
- Avoid unnecessary narrowing cast on _Py_write_noraise() call.
* snprintf() is not async-signal-safe: replace it with _Py_DumpDecimal(). * Fix tid type from 'long' to 'unsigned long'. * Replace PyLong_AsLong() with PyLong_AsInt(). * Avoid unnecessary narrowing cast on _Py_write_noraise() call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.