gh-149945: Fix potential OOM for gzip with large header#149979
Merged
serhiy-storchaka merged 1 commit intoMay 19, 2026
Conversation
Do not read the whole filename and comment to memory for calculating the CRC.
serhiy-storchaka
added
skip news
needs backport to 3.15
Contributor
|
I did not foresee this can of worms... Alternative: if flag & FHCRC:
warnings.warn("Header CRC is set but will not be checked by python")The code looks good to me. Very elegant solution. A long header will take a long time to calculate due to the overhead of reading it byte by byte, but that byte by byte reading is what always has been done so probably not too problematic. |
Member
Author
|
Yes, I also missed it. |
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-150093 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
serhiy-storchaka
added a commit
that referenced
this pull request
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not read the whole filename and comment to memory for calculating the CRC.
cc @rhpvorderman, @KowalskiThomas