Repository navigation
gh-148919: Make test_redirect_no_path independent of proxy environment variables - #148920
Merged
Merged
Conversation
…ronment variables
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Contributor
Author
|
Test-fix only, I think this PR should add a label 'skip news'. |
|
This PR is stale because it has been open for 90 days with no activity. |
Contributor
Author
|
/touch |
Contributor
Author
|
/label remove stable |
Contributor
Author
|
/label remove /stale |
Contributor
Author
|
/label remove stale |
github-actions
Bot
removed
the
stale
…y env test_redirect_encoding uses build_opener(), which installs the default ProxyHandler, so it failed the same way when http_proxy was set. Move the environment cleanup into a helper and use EnvironmentVarGuard.unset(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
I verified this bug. The change is required in test_redirect_encoding too. |
orsenthil
added
needs backport to 3.14
orsenthil
approved these changes
Oct 28, 2026
|
Thanks @sendaoYan for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-160846 is a backport of this pull request to the 3.15 branch. |
|
GH-160847 is a backport of this pull request to the 3.14 branch. |
orsenthil
added a commit
that referenced
this pull request
Oct 28, 2026
…ironment variables (GH-148920) (#160846) gh-148919: Make test_redirect_no_path independent of proxy environment variables (GH-148920) * gh-148919: Make test_redirect_no_path independent of proxy environment variables * gh-148919: Also make test_redirect_encoding independent of proxy env test_redirect_encoding uses build_opener(), which installs the default ProxyHandler, so it failed the same way when http_proxy was set. Move the environment cleanup into a helper and use EnvironmentVarGuard.unset(). --------- (cherry picked from commit d854380) Co-authored-by: sendaoYan <yansendao@hygon.cn> Co-authored-by: Senthil Kumaran <senthil@python.org> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
orsenthil
added a commit
that referenced
this pull request
Oct 28, 2026
…ironment variables (GH-148920) (#160847) gh-148919: Make test_redirect_no_path independent of proxy environment variables (GH-148920) test_redirect_encoding uses build_opener(), which installs the default ProxyHandler, so it failed the same way when http_proxy was set. Move the environment cleanup into a helper and use EnvironmentVarGuard.unset(). --------- (cherry picked from commit d854380) Co-authored-by: sendaoYan <yansendao@hygon.cn> Co-authored-by: Senthil Kumaran <senthil@python.org> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test.test_urllib2.HandlerTests.test_redirect_no_path can fail when proxy-related environment variables are set (for example, http_proxy / HTTP_PROXY).
This change makes the test self-contained by clearing proxy-related environment variables within the test via test.support.os_helper.EnvironmentVarGuard.
Rationale
The test is intended to verify relative redirect behavior (Location: ?query) and should not depend on external shell/network proxy configuration.
When proxy env vars are active, request targets may be sent in absolute-form (http://python.org/path) instead of origin-form (/path), which breaks the current assertion and introduces environment-dependent failures.
Changes
Update Lib/test/test_urllib2.py in test_redirect_no_path:
Add EnvironmentVarGuard
Remove proxy-related variables (lowercase and uppercase variants, including no_proxy / NO_PROXY) for the duration of the test