gh-148442: eliminate race condition in list rich comparison#148531
Draft
KowalskiThomas wants to merge 5 commits intopython:mainfrom
Draft
gh-148442: eliminate race condition in list rich comparison#148531KowalskiThomas wants to merge 5 commits intopython:mainfrom
KowalskiThomas wants to merge 5 commits intopython:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR?
This PR is a fix for #148442, where the
list's rich comparison function could return an incorrect result due a race condition in non-trivial__eq__implementations of list elements.It also updates
test_equal_operator_modifying_operandwhich would previously assert two different lists were equal; it now properly asserts they are different.list's rich comparison has a race condition for non-trivial__eq__and may return an incorrect result #148442