Open
Conversation
Member
ZeroIntensity
left a comment
There was a problem hiding this comment.
Thanks for tackling these.
|
|
||
|
|
||
| .. c:function:: PyObject* PyDescr_NewWrapper(PyTypeObject *type, struct wrapperbase *wrapper, void *wrapped) | ||
| .. c:function:: PyObject* PyDescr_NewWrapper(PyTypeObject *type, struct wrapperbase *base, void *wrapped) |
Member
There was a problem hiding this comment.
wrapperbase is undocumented as well -- can we fix that in this PR?
Comment on lines
+13
to
+14
| Create a new get-set descriptor for extension type *type* from the | ||
| :c:type:`PyGetSetDef` structure *getset*. |
Member
There was a problem hiding this comment.
Let's elaborate a little more (the same goes for the ones below):
- What is a get-set descriptor, exactly?
- Why do users care? (Or, what might they use this for?)
- What does this correspond to in Python?
Author
|
Implemented, thanks! I expanded the new descriptor docs to explain:
I also documented |
Author
|
Added a follow-up to remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This documents several missing entries in
Doc/c-api/descriptor.rst.Changes in this PR:
PyDescr_NewGetSetPyDescr_NewMemberPyDescr_NewMethodPyDescr_NewWrapperPyDescr_NewClassMethodPyWrapper_Newtypesmodule namesThis is a docs-only change.
📚 Documentation preview 📚: https://cpython-previews--146644.org.readthedocs.build/