gh-144763: Don't detach the GIL in tracemalloc#144779
Open
vstinner wants to merge 2 commits intopython:mainfrom
Open
gh-144763: Don't detach the GIL in tracemalloc#144779vstinner wants to merge 2 commits intopython:mainfrom
vstinner wants to merge 2 commits intopython:mainfrom
Conversation
tracemalloc no longer detachs the GIL to acquire its internal lock.
Don't call PyRefTracer_SetTracer() while holding TABLES_LOCK().
Member
Author
| int lineno = -1; | ||
| PyCodeObject *code = _PyFrame_GetCode(pyframe); | ||
| // PyUnstable_InterpreterFrame_GetLine() cannot but used, since it uses | ||
| // a critical section which can trigger a deadlock. |
Contributor
There was a problem hiding this comment.
I think the problem is that critical sections requires an active thread state and this code can be called with detached thread state iirc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracemalloc no longer detachs the GIL to acquire its internal lock.
_io_TextIOWrapper_write_implwhen runningtracemalloc.clear_tracesin threads #144763