Skip to content

GH-138800: fix variable substitution in python3.pc for Android#144776

Open
thunder-coding wants to merge 1 commit intopython:mainfrom
thunder-coding:android-pkgconfig
Open

GH-138800: fix variable substitution in python3.pc for Android#144776
thunder-coding wants to merge 1 commit intopython:mainfrom
thunder-coding:android-pkgconfig

Conversation

@thunder-coding
Copy link

@thunder-coding thunder-coding commented Feb 13, 2026

$(BLDLIBRARY) substitution works in Makefiles where variables are expanded at the time of execution. This expansion does not happen in static files like .pc, so use value of BLDLIBRARY instead of trying to substitute the value.

Patch stolen from downstream distribution of Python for Termux (Android): termux/termux-packages#27739

Preferably needs to be backported to both Python 3.13 as well as Python 3.14, along with the main branch

Fixes #138800

@python-cla-bot
Copy link

The following commit authors need to sign the Contributor License Agreement:

CLA not signed

@bedevere-app
Copy link

bedevere-app bot commented Feb 13, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@thunder-coding
Copy link
Author

I'd be happy to sign the CLA, but not happy with providing Python's GitHub app with API access to act on my behalf. I'm attaching a PGP signed message, please consider it as my signed version of CLA:

-----BEGIN PGP MESSAGE-----

owGbwMvMwCX296bGzVSFAjHGtYxsSezJOYl6JRUlmX2nKj11FCITs4szFJwSizIr
E3UUMlKLUpMqFYoz0/MUAipLMvLz1IsVnPPzSooyk0pL8osUfDKTU/OKUxUc04tS
U3NT80oUNJx9HDUVyjITFXIrFQLcAxQKijLLEktSFbJTK/W4uDwVEpOz8/LLc1JT
0lMVSjISSxQ81ctSFYpSE1MUMkpKCoqt9PVBTioAW6eXX5Sur5CYh5ArLy9Hliso
TtNPhjgIRuum5RflQjQlgpylUJKvkJiTA7QMyEwtyi1WADk0Mz8vNUUhM08hs0SP
q6OUhUGMi0FWTJFlioD/5OjgpM2ifNsPwgKKlQkUOgxcnAIwkXgBhv9eP8T33rKZ
/lTlSZ9l1XldZY2TetfcW+YenPl5OXfsUl0HRoYml2dvrusdlVX5oX2jVESKtdy4
M1rRY3dsaueaGJ6v5TwA
=AKa8
-----END PGP MESSAGE-----
image

@emmatyping
Copy link
Member

@thunder-coding if you do not want to sign the CLA with CLA bot you can fill out the form here: https://www.python.org/psf/contrib/contrib-form/

You could also use the bot and revoke the permissions afterwards. It is open source: https://github.com/psf/clabot

$(BLDLIBRARY) substitution works in Makefiles where variables are
expanded at the time of execution. This expansion does not happen in
static files like .pc, so use value of BLDLIBRARY instead of trying to
substitute the value.

Patch stolen from downstream distribution of Python for Termux
(Android): termux/termux-packages#27739

Preferably needs to be backported to both Python 3.13 as well as Python
3.14, along with the main branch

Fixes python#138800
@mhsmith mhsmith added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.pc for Android contains invalid syntax

3 participants