gh-128213: fast path for bytes creation from list and tuple - #132590
Merged
kumaraditya303 merged 38 commits intoSep 12, 2026
Merged
gh-128213: fast path for bytes creation from list and tuple#132590kumaraditya303 merged 38 commits into
kumaraditya303 merged 38 commits into
Conversation
…sing PyNumber_AsSsize_t; fixed indentation
eendebakpt
marked this pull request as draft
April 16, 2025 12:41
eendebakpt
marked this pull request as ready for review
April 16, 2025 14:09
eendebakpt
commented
Feb 6, 2026
Contributor
Author
|
@markshannon Would you be able to continue reviewing this one? |
…rom-list-tuple-2 # Conflicts: # Objects/bytesobject.c
Contributor
Author
|
@colesbury Would you be able to review? |
|
This PR is stale because it has been open for 90 days with no activity. |
Use the PyDict_GetItemRef()-style tri-state contract instead: return 1 on success with *result set, 0 to fall back to the slow path, and -1 on error with an exception set. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…rom-list-tuple-2 # Conflicts: # Objects/bytesobject.c
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
eendebakpt
commented
Sep 11, 2026
kumaraditya303
approved these changes
Sep 12, 2026
clin1234
pushed a commit
to clin1234/cpython
that referenced
this pull request
Sep 12, 2026
…thon#132590) Co-authored-by: Ben Hsing <blhsing@gmail.com> Co-authored-by: Kumar Aditya <kumaraditya@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #128214. This PR
_PyList_GetItemRef).