Skip to content

Replace placeholder text in the http.client module docstring - #121490

Merged
StanFromIreland merged 3 commits into
python:mainfrom
samrobbins85:patch-1
Oct 30, 2026
Merged

Replace placeholder text in the http.client module docstring#121490
StanFromIreland merged 3 commits into
python:mainfrom
samrobbins85:patch-1

Conversation

@samrobbins85

@samrobbins85 samrobbins85 commented Jul 8, 2024

Copy link
Copy Markdown
Contributor

Removes template lines in the comment so that hovering over the library in an IDE shows the documentation rather than these lines

@ghost

ghost commented Jul 8, 2024 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app

bedevere-app Bot commented Jul 8, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@samrobbins85 samrobbins85 changed the title Update http client to include template in comment Update http client to remove template in comment Jul 8, 2024
@ziima

ziima commented Jul 13, 2024

Copy link
Copy Markdown
Contributor

Looks good to me.

@github-actions

github-actions Bot commented Apr 17, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 17, 2026
@bedevere-app

bedevere-app Bot commented Oct 28, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-app Bot commented Oct 30, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@StanFromIreland StanFromIreland changed the title Update http client to remove template in comment Replace placeholder text in the http.client module docstring Oct 30, 2026
@StanFromIreland StanFromIreland added awaiting review needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes and removed awaiting merge labels Oct 30, 2026
@StanFromIreland
StanFromIreland enabled auto-merge (squash) October 30, 2026 13:53
@StanFromIreland

StanFromIreland commented Oct 30, 2026

Copy link
Copy Markdown
Member

Thanks for the PR @samrobbins85, I pushed a little commit to replace the placeholder rather than remove it. Sorry for the delay!

@StanFromIreland
StanFromIreland merged commit 4a9b981 into python:main Oct 30, 2026
69 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in HTTP issues Oct 30, 2026
@miss-islington-app

miss-islington-app Bot commented Oct 30, 2026

Copy link
Copy Markdown

Thanks @samrobbins85 for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Oct 30, 2026

Copy link
Copy Markdown

GH-160969 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 30, 2026
@bedevere-app

bedevere-app Bot commented Oct 30, 2026

Copy link
Copy Markdown

GH-160970 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 30, 2026
StanFromIreland added a commit that referenced this pull request Oct 30, 2026
@miss-islington @samrobbins85 @StanFromIreland
[3.15] Replace placeholder text in the http.client module docstring (…
fe305f8 
…GH-121490) (#160969)

(cherry picked from commit 4a9b981)

Co-authored-by: Sam Robbins <samrobbinsgb@gmail.com>
Co-authored-by: Stan Ulbrych <stan@python.org>
StanFromIreland added a commit that referenced this pull request Oct 30, 2026
@miss-islington @samrobbins85 @StanFromIreland
[3.14] Replace placeholder text in the http.client module docstring (…
7cd4079 
…GH-121490) (#160970)

(cherry picked from commit 4a9b981)

Co-authored-by: Sam Robbins <samrobbinsgb@gmail.com>
Co-authored-by: Stan Ulbrych <stan@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes

Assignees

No one assigned

Labels

skip issue skip news stale Stale PR or inactive for long period of time.

Projects

HTTP issues
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samrobbins85 @ziima @StanFromIreland