Skip to content

feat(resolver): dispatch configured source resolvers - #1325

Merged
LalatenduMohanty merged 2 commits into
python-wheel-build:new-resolver-configfrom
LalatenduMohanty:feat/1292-source-resolver-dispatch
Sep 10, 2026
Merged

feat(resolver): dispatch configured source resolvers#1325
LalatenduMohanty merged 2 commits into
python-wheel-build:new-resolver-configfrom
LalatenduMohanty:feat/1292-source-resolver-dispatch

Conversation

@LalatenduMohanty

Copy link
Copy Markdown
Member

Route packages with source resolver configuration through the configured provider while preserving legacy override behavior. Add coverage for source and bootstrap resolution paths and document the dispatch.

Refs: #1292

Pull Request Description

What

Why

@LalatenduMohanty
LalatenduMohanty requested a review from a team as a code owner September 10, 2026 13:44
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 838804bb-341e-4806-abd5-09a6cb06ac56

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@LalatenduMohanty
LalatenduMohanty marked this pull request as draft September 10, 2026 13:44
@mergify mergify Bot added the ci label Sep 10, 2026
@LalatenduMohanty
LalatenduMohanty force-pushed the feat/1292-source-resolver-dispatch branch from b7c3c24 to 9cdcb36 Compare September 10, 2026 13:45
LalatenduMohanty and others added 2 commits September 10, 2026 09:48
Route packages with source resolver configuration through the configured
provider while preserving legacy override behavior. Widen
`AbstractResolver.resolver_provider` to accept `RequirementType | None`
and remove the `typing.cast` that hid the mismatch. Add coverage for
source and bootstrap resolution paths and document the dispatch.

Refs: python-wheel-build#1292
Co-Authored-By: Claude <claude@anthropic.com>
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
…lvers

Source resolvers bypassed `resolve_package_cooldown()`, so the global
`--min-release-age` flag was silently ignored and top-level `==` pins
did not disable the cooldown.

Extract `_effective_cooldown()` from `resolve_package_cooldown()` and
call it in the source-resolver dispatch path so both legacy and
configured resolvers share the same cooldown merge logic.

Refs: python-wheel-build#1292
Co-Authored-By: Claude <claude@anthropic.com>
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
@LalatenduMohanty
LalatenduMohanty force-pushed the feat/1292-source-resolver-dispatch branch from 9cdcb36 to b3de3e3 Compare September 10, 2026 17:28
@LalatenduMohanty
LalatenduMohanty marked this pull request as ready for review September 10, 2026 17:33

@rd4398 rd4398 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks

@mergify

mergify Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@LalatenduMohanty
LalatenduMohanty merged commit a8984bc into python-wheel-build:new-resolver-config Sep 10, 2026
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants