fix(bootstrap): don't call get_resolver_provider hook in cache lookups

[LalatenduMohanty]

_download_wheel_from_cache() called resolver.resolve(), which triggered custom resolver hooks. Cache servers are always simple PyPI index servers and don't need hook-based resolution. Call default_resolver_provider() directly instead.

Closes: #1049

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a404ae2c-786b-4032-9290-9f74be6db241

📥 Commits

Reviewing files that changed from the base of the PR and between 9abd5dd and 986fb38.

📒 Files selected for processing (2)

• src/fromager/bootstrapper.py
• tests/test_bootstrapper.py

🚧 Files skipped from review as they are similar to previous changes (2)

• src/fromager/bootstrapper.py
• tests/test_bootstrapper.py

---

📝 Walkthrough

Walkthrough

The _download_wheel_from_cache function was changed to avoid invoking resolver hooks. Instead of calling resolver.resolve() with a requirement spec, it constructs a pinned requirement like name==version, instantiates resolver.PyPIProvider pointed at self.cache_wheel_server_url (with include_sdists=False, include_wheels=True, and the current constraints), and calls resolver.find_all_matching_from_provider(provider, pinned_req) to obtain a wheel URL. Existing logic for parsing the wheel URL, validating build tags, downloading, and unpacking metadata is unchanged. A unit test was added to assert the resolver hook path is not invoked during cache lookups.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: bypassing the get_resolver_provider hook in cache lookups during bootstrap.
Description check	✅ Passed	The description clearly explains why the change was made and references the problem it solves.
Linked Issues check	✅ Passed	The PR implementation satisfies issue #1049: it prevents _download_wheel_from_cache from invoking the get_resolver_provider hook by directly instantiating PyPIProvider instead of calling resolver.resolve().
Out of Scope Changes check	✅ Passed	All changes are in-scope: modifications to _download_wheel_from_cache cache lookup logic and a focused test validating the hook-bypass behavior.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/fromager/bootstrapper.py`:
- Around line 1113-1114: The code currently takes the first candidate from
resolver.find_all_matching_from_provider (results[0]) and treats it as a miss if
it fails the build-tag check; instead iterate over the results array for the
pinned_req and pick the first (wheel_url, metadata) whose
build-tag/compatibility check passes (the same logic used later around the
1124-1131 build-tag verification), only falling back to (None, None) if no
candidate matches; update both the immediate use (where results[0] is read) and
the similar block covering lines 1124-1131 to perform this filtered selection so
later valid cache entries aren’t ignored.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7e540214-986a-4d2e-9422-b35ef46423a9

📥 Commits

Reviewing files that changed from the base of the PR and between b8f4441 and 9abd5dd.

📒 Files selected for processing (2)

• src/fromager/bootstrapper.py
• tests/test_bootstrapper.py

[tiran]

Looks good to me.

I would appreciate a second opinion from @rd4398 or @dhellmann .

[rd4398]

This looks good!

[mergify]

Deprecation notice: This pull request comes from a fork and was rebased using bot_account impersonation. This capability will be removed on July 1, 2026. After this date, the rebase action will no longer be able to rebase fork pull requests with this configuration. Please switch to the update action/command to ensure compatibility going forward.