feat(graph): add pre-rebuild-check Claude Code skill#1017
feat(graph): add pre-rebuild-check Claude Code skill#1017stmcgovern wants to merge 3 commits intopython-wheel-build:mainfrom
Conversation
Add a skill that runs `fromager graph check`, interprets results, and recommends constraint fixes grouped by leverage. Closes: python-wheel-build#1012
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds a new Claude Code skill document at Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.claude/commands/pre-rebuild-check.md:
- Line 41: The document contains an internal inconsistency between the
"Required" severity wording: one spot states "will fail" (and a header reads
"Required → blocker. write_constraints_file will fail") while another says "will
likely fail"; make the policy wording consistent by choosing one phrasing and
updating both occurrences: either change the stronger instance to "will likely
fail" or the weaker one to "will fail", and ensure the header/severity label
("Required → blocker") and the mention of write_constraints_file reflect the
chosen wording so all references are identical.
- Line 47: The "Constraints block" instruction is wrong — replace the
non-existent `graph check --constraints` flow with the implemented command
`fromager graph to_constraints <graph.json>` so users run `fromager graph
to_constraints <graph.json>` and paste that output into constraints.txt; update
the text under the "Constraints block" heading to reference `fromager graph
to_constraints`, `constraints.txt`, and describe that the command produces a
ready-to-paste constraints block.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c9d5908c-eba8-4149-b85d-cdf489822c11
📒 Files selected for processing (2)
.claude/commands/pre-rebuild-check.md.gitignore
Use "will likely fail" consistently for required conflicts.
Summary
.claude/commands/pre-rebuild-check.md— a Claude Code skill that runsfromager graph check, interprets the output, and recommends constraint fixes.gitignoreto allow.claude/commands/while keeping other Claude state ignoredThe skill guides the assistant to:
graph checkagainst a build's graph.jsonDepends on #999 (
graph checkcommand).Closes: #1012