Skip to content

fix: skip non-regular files in scan_compiled_extensions #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikedep333 wants to merge 1 commit into from
Closed

fix: skip non-regular files in scan_compiled_extensions #1002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/fromager/sources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,6 +859,8 @@ def scan_compiled_extensions(
for directory, _, filenames in root_dir.walk():
for filename in filenames:
filepath = directory / filename
if not filepath.is_file():
continue
Comment on lines +862 to +863
Copy link
Copy Markdown
Collaborator

@tiran tiran Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_file use a syscall. I have written the code in a way that reduces the amount of syscalls and I/O activity.

Can you move right before filepath.open and add a comment why it is needed?

Copy link
Copy Markdown
Member Author

@mikedep333 mikedep333 Apr 1, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update this commit to improve vs #1004 , which was merged

suffix = filepath.suffix
if suffix in extension_suffixes:
relpath = filepath.relative_to(root_dir)
Expand Down
Loading