Fix bounds for multi-member and wrapped GeometryCollections - #2281
Open
jokrasno wants to merge 1 commit into
Open
Fix bounds for multi-member and wrapped GeometryCollections#2281jokrasno wants to merge 1 commit into
jokrasno wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeoJson.get_bounds()currently considers only the first member of a GeometryCollection. For example, a collection containing points[2, 1]and[40, 30]returns[[1, 2], [1, 2]], excluding the second point. Wrapping a collection in a Feature raisesKeyError, and an empty collection raisesIndexError.Recursively traverse Features, FeatureCollections, and all GeometryCollection members in
iter_coords. This handles nested and empty collections while preserving null-geometry handling. Follow-up to #1599 and #1633, whose regression covers a single member.Validation:
python -B -m pytest tests/test_features.py tests/test_utilities.py tests/test_vector_layers.py -q --tb=short— 116 passed (one existing pytest deprecation warning).git diff --checkpass.