Skip SSL tests on Windows x86 CI#3468
Conversation
|
This feels like an LLM pull request to me, please actually review your pull requests instead of outsourcing. This does not solve the problem as you can see if you look at the actions run results, and I think in the end this is going to have to come down to making trio able to work without cryptography installed albeit with a more limited feature set if cryptography is not installed, just dropping support for x86 windows, or trying to have trio work with the old version that supported x86 windows at the same time as the new version (but this sounds hard and would likely increase maintenance load). Personally leaning towards option two and just telling x86 windows people to use an older version of trio, but would like to hear other's thoughts. |
|
My PoV is that the only place where Trio needs PyOpenSSL is dtls and I don't think we even depend on it. (PyOpenSSL uses cryptography iirc) I guess it wasn't clear but the deprecation warning is from the cryptography package, not built in SSL. So I was thinking just a pytest.skip in the relevant test files. (but I didn't quite realize trustme depends on it too, so IDK if it's possible) I agree this PR is bad though! |
Closes #3466
Summary
Validation
No newsfragment added because this is CI-only maintenance with no user-visible behavior change.