Keep the Error object an exception is built from - #168
Merged
Merged
Conversation
SCIMException.from_error() rebuilt the status and the scimType from the exception class, so everything it has no class for was lost: a 429 status came back as 400, and a vendor specific scimType came back empty. to_error() now gives back the object it was built from. A client turning a server error into an exception and back into an HTTP response no longer changes the status the server sent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SCIMException.from_error() rebuilt the status and the scimType from the exception class, so everything it has no class for was lost: a 429 status came back as 400, and a vendor specific scimType came back empty. to_error() now gives back the object it was built from.
A client turning a server error into an exception and back into an HTTP response no longer changes the status the server sent.