Skip to content

Preserve markdown download handling - #139

Merged
timkpaine merged 1 commit into
mainfrom
tkp/hf2
Aug 17, 2026
Merged

Preserve markdown download handling#139
timkpaine merged 1 commit into
mainfrom
tkp/hf2

Conversation

@timkpaine

@timkpaine timkpaine commented Aug 17, 2026

Copy link
Copy Markdown
Member

Call MarkdownBuilder.finish() from Yardang's explicit yardang-llms builder so sphinx-markdown-builder 0.6.11 can copy referenced downloads.

Without the parent lifecycle hook, direct builder output contains _downloads links but omits the files. Regression coverage builds with yardang-llms and verifies the generated link resolves to a copied file.

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Test Results

84 tests  +1   84 ✅ +1   25s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit dec2ac9. ± Comparison against base commit 7003778.

@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.38%. Comparing base (bc1f53d) to head (dec2ac9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   80.60%   85.38%   +4.78%     
==========================================
  Files          15       15              
  Lines        1897     1909      +12     
  Branches      203      203              
==========================================
+ Hits         1529     1630     +101     
+ Misses        317      216     -101     
- Partials       51       63      +12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timkpaine
timkpaine marked this pull request as ready for review August 17, 2026 23:02
@timkpaine
timkpaine merged commit ec470bb into main Aug 17, 2026
4 checks passed
@timkpaine
timkpaine deleted the tkp/hf2 branch August 17, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant