Repository navigation
Add pnpm dependency license bundles - #53
Merged
Merged
Conversation
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
===========================================
+ Coverage 72.97% 96.62% +23.64%
===========================================
Files 8 12 +4
Lines 148 681 +533
===========================================
+ Hits 108 658 +550
+ Misses 40 23 -17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add opt-in pnpm dependency license collection to hatch-js.
licenses.destinationselects a package-relative JSON bundle in the wheel. Collection runs after the JavaScript build, usespnpm licenses list --json, and retains original license and notice texts without machine-specific paths or newline normalization.Include development and optional dependencies by default because bundlers can ship code declared in dev dependencies.
production-onlyselects pnpm's--prodlisting without changing installation or build commands. Document the conservative graph scope, workspace/platform limits, and need for human compliance review.Reject missing/invalid texts, malformed graphs, unsafe paths, destination collisions, and conflicting originals. Exact-name/version/license-expression
previousoverrides can fill missing files, including absentSEE LICENSE IN ...targets, while preserving existing notices. Notice-only overrides cannot satisfy the license requirement.Force-include bundles in standard and editable wheels, preserve other hooks' outputs and forced-inclusion precedence, and remove temporary files after packaging. Skip sdists and
SKIP_HATCH_JS. Existing npm/yarn/jlpm builds are unchanged; enabling collection for them fails explicitly.Pin CI to pnpm 10.28.2 through the existing setup action. Add
editablesonly to development dependencies for real editable-wheel tests. Runtime dependencies and project version are unchanged; no release or tag created.Checked on macOS arm64 / Python 3.12.14:
make lint,make coverage,make checks, andty checkpass: 73 tests, 96.6% repository coverage.Implemented in an isolated worktree based on current upstream main 0f46f24; the original local checkout remains unchanged. Keeping this PR draft for review.
Type of Change
Checklist
make lint)make test)