Skip to content

Simplify code by removing chown and chmod #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 1 commit into from
Jul 18, 2026
+4 −14
Merged

Simplify code by removing chown and chmod #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,22 +69,21 @@ jobs:
else
git submodule update --remote Pillow
fi
(cd Pillow && git checkout main)
sudo chown -R 1001 "$(pwd)"
cd Pillow && git checkout main

- name: Test Image Build
if: "matrix.test-image"
run: |
cd "${{ matrix.test-image }}"
make pull || (sudo chmod a+w . && make update && make build BRANCH=main)
make pull || (make update && make build BRANCH=main)
env:
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
DOCKER_ARGS: ${{ matrix.docker-args }}

- name: Build image
id: build
run: |
cd "${{ matrix.image }}" && sudo chmod a+w . && make update
cd "${{ matrix.image }}" && make update
if [[ -n "$DOCKER_USERNAME" ]]; then
echo "$DOCKER_PASSWORD" | docker login -u "$DOCKER_USERNAME" --password-stdin && echo "logged_in=true" >> "$GITHUB_OUTPUT"
fi
Expand Down Expand Up @@ -113,10 +112,6 @@ jobs:
env:
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}

- name: Post build
if: always()
run: sudo chown -R "$(id -u)" "$(pwd)"

# The valgrind suite is slow, so build its image once, test it across
# parallel split jobs, and push only after every split has passed.
build-valgrind:
Expand Down Expand Up @@ -176,8 +171,7 @@ jobs:
- name: Prepare test
run: |
git submodule update --remote Pillow
(cd Pillow && git checkout main)
sudo chown -R 1001 "$(pwd)"
cd Pillow && git checkout main

- name: Load image
run: |
Expand All @@ -197,10 +191,6 @@ jobs:
SPLIT_INDEX: ${{ matrix.split }}
SPLIT_COUNT: ${{ strategy.job-total }}

- name: Post test
if: always()
run: sudo chown -R "$(id -u)" "$(pwd)"

push-valgrind:
name: Push ubuntu-24.04-noble-amd64-valgrind
needs: test-valgrind
Expand Down
Loading