Skip to content

Do not use CodSpeedHQ/action on pull requests to a fork #9761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
radarhere wants to merge 5 commits into from
Closed

Do not use CodSpeedHQ/action on pull requests to a fork #9761

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
560db1f
Use python3
radarhere Jul 1, 2026
4b3a31a
Do not use CodSpeedHQ/action on pull requests to a fork
radarhere Jul 3, 2026
97d6e80
Merge branch 'main' into benchmark
radarhere Aug 3, 2026
5af014c
Merge branch 'main' into benchmark
radarhere Aug 7, 2026
a3e21d2
Merge branch 'main' into benchmark
radarhere Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,16 @@ jobs:
GHA_LIBWEBP_CACHE_HIT: ${{ steps.cache-libwebp.outputs.cache-hit }}

- name: Run CodSpeed benchmarks
if: github.event_name != 'pull_request' || github.event.repository.fork == false

@akx akx Sep 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe simply

Suggested change
if: github.event_name != 'pull_request' || github.event.repository.fork == false
if: github.event.repository.fork == false

in conjunction with the below (see rationale there).

WDYT?

uses: CodSpeedHQ/action@373d6868929f444bc08d901fd0eb0ad52a8875ea # v5.2.1
with:
mode: simulation
run: |
python3 -m pip install -e . pytest-codspeed
pytest -vv --codspeed Tests/benchmarks.py
python3 -m pytest -vv --codspeed Tests/benchmarks.py

- name: Run CodSpeed benchmarks on pull requests to a fork
if: github.event_name == 'pull_request' && github.event.repository.fork == true
run: |
python3 -m pip install -e . pytest-codspeed
python3 -m pytest -vv --codspeed Tests/benchmarks.py
Comment on lines +99 to +103

@akx akx Sep 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this alternate is really needed. If you're not using the codspeed action (that does CPU simulation and other deep magic), you're not going to get comparable numbers anyhow.

Suggested change
- name: Run CodSpeed benchmarks on pull requests to a fork
if: github.event_name == 'pull_request' && github.event.repository.fork == true
run: |
python3 -m pip install -e . pytest-codspeed
python3 -m pytest -vv --codspeed Tests/benchmarks.py