Fix BMP RLE delta escape reading from wrong file position#9443
Merged
hugovk merged 3 commits intopython-pillow:mainfrom Feb 21, 2026
Merged
Fix BMP RLE delta escape reading from wrong file position#9443hugovk merged 3 commits intopython-pillow:mainfrom
hugovk merged 3 commits intopython-pillow:mainfrom
Conversation
Member
|
https://www.digicamsoft.com/bmp/bmp.html supports your change
|
Contributor
Author
|
Thanks for confirming with the spec, glad the fix aligns with what the BMP reference says. |
Merged
Member
|
I've created bysiber#3 to add a test. |
radarhere
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BMP RLE decoder's delta escape handler reads the displacement bytes twice from the file stream. It reads 2 bytes into
bytes_readfor validation, then callsself.fd.read(2)again instead of unpackingbytes_read:The real delta displacement values are thrown away, and
right/upcome from whatever happens to be next in the stream. Any RLE-compressed BMP that uses delta escape codes gets decoded with wrong pixel offsets, producing corrupted output.