Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing a class produced by
collections.namedtuplecan maketextDocument/documentSymbolfail withTypeErrorwhen Jedi supplies generated members whosemodule_pathisNone.Skip those members before constructing a
Path. The imported class and the document's own symbols retain their locations. Regression coverage exercises both values ofall_scopesandinclude_import_symbolswith a real relative import.Fixes #635.
Validation: two regression cases fail before the fix and two controls pass. The symbols, definitions and type-definition suites pass after the fix (19 passed, 1 platform-specific test skipped). Ruff 0.9.4 lint and formatting checks pass for both changed files.