Handling list merge in _utils.merge_dicts().#38
Merged
ccordoba12 merged 1 commit intopython-lsp:developfrom Jun 3, 2021
Merged
Handling list merge in _utils.merge_dicts().#38ccordoba12 merged 1 commit intopython-lsp:developfrom
ccordoba12 merged 1 commit intopython-lsp:developfrom
Conversation
Member
|
What problem does this fix? And, could you add a test case for it? |
Contributor
Author
In practice, I faced this edge case while having flake8 ignores both in my neovim config (LS client) and others in my project flake8 config ( |
Member
|
Ok, I think it's fine. Merging then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a list value is present in both dicts, they are merged (with duplicates removed).