Simplify GCDisabledGuard constructor - #529
Merged
Merged
Conversation
Combine PyGC_IsEnabled and PyGC_Disable into PyGC_Disable as it already returns previous state of garbage collector.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combine PyGC_IsEnabled and PyGC_Disable into PyGC_Disable as it already returns previous state of garbage collector.
A little bit of background: I was building an app using free-threaded python and sqlalchemy with asyncpg - 4-8 threads each with connection to postgres. What I found is very slow (although at this early stage data volume was also low) memory leak of ~100MB/day.
After checking it further with Claude - found by injecting that live app had disabled GC. Further check of what could be disabling GC led to this part of code in greenlet, due to race condition of 2 separate threads accessing GC state at a different time. I've build a patched version with this very change and now the leak is gone.
Can't say that there is no other problem in here with free-threading, but at the very least, this should make it less likely.