feat: add DALL1xx for __dir__#92
Open
henryiii wants to merge 3 commits into
Open
Conversation
repo-helper
Bot
added
failure: mypy
henryiii
force-pushed
the
henryiii/feat/__dir__
branch
from
f17d744 to
40a16aa
Compare
repo-helper
Bot
added
failure: Linux
henryiii
force-pushed
the
henryiii/feat/__dir__
branch
from
40a16aa to
8951144
Compare
repo-helper
Bot
removed
failure: Linux
henryiii
force-pushed
the
henryiii/feat/__dir__
branch
from
8951144 to
453ecf9
Compare
repo-helper
Bot
added
failure: flake8
henryiii
force-pushed
the
henryiii/feat/__dir__
branch
from
453ecf9 to
16ec0c1
Compare
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
henryiii
force-pushed
the
henryiii/feat/__dir__
branch
from
16ec0c1 to
6886446
Compare
repo-helper
Bot
removed
failure: Linux
Noticed by a GPT-5.5 review. Assisted-by: ClaudeCode:claude-opus-4.8 Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Address review feedback on the DALL1xx __dir__ checks: - DALL100 no longer fires on memberless modules; the __dir__ requirement now mirrors DALL101 and applies only when public members exist. - Drop the unused Visitor.found_lineno and add the missing found_dir attribute annotation. - Simplify the DALL000 branch and tighten the test code filter (startswith instead of substring); restore the deliberate noqa split in test_subprocess. Assisted-by: ClaudeCode:claude-opus-4.8 Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Contributor
Author
|
A couple of rounds of automated reviews removing unneeded code and this looks pretty good now, I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #86.
Adds a check for
__dir__, split into two codes (one for__init__). The__init__check will not trigger unless something is defined in init.