Conversation
Also: - Update documentation on mixins - Add a mixin.py example - Move ruff config to ruff.toml - Upgrade to ruff 0.13.1
|
🤖 Hi @tleonhardt, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1523 +/- ##
==========================================
+ Coverage 98.90% 98.92% +0.02%
==========================================
Files 21 21
Lines 4933 4933
==========================================
+ Hits 4879 4880 +1
+ Misses 54 53 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
📋 Review Summary
This pull request is a nice cleanup and refactoring. It removes the outdated plugins directory and replaces it with clearer documentation and examples for using mixins to extend cmd2. The move of the ruff configuration to its own file is also a good improvement.
🔍 General Feedback
- The new documentation for mixins is well-written and helpful.
- The example code is clear and demonstrates the concepts well.
- The project structure is cleaner with the removal of the
pluginsdirectory.
Delete
pluginsdirectory as this felt outdated and not really relevant within thecmd2repo itself.Also:
cmd2mixin.pyexampleruffconfig toruff.toml(frompyproject.tomlruffto 0.13.1 (from 0.13.0)