Conversation
…n documentation, the following changes were made. - No longer redirecting sys.stdout. - No longer capturing pyscript output written to sys.stdout.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1468 +/- ##
==========================================
- Coverage 98.41% 98.41% -0.01%
==========================================
Files 21 21
Lines 5863 5856 -7
==========================================
- Hits 5770 5763 -7
Misses 93 93
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tleonhardt
approved these changes
Jul 21, 2025
Member
tleonhardt
left a comment
There was a problem hiding this comment.
It isn't clear to me if it is better to do this or to eliminate self.stdout.
I think this is probably fine.
Member
Author
|
I'm going to close this and take a different approach. I will preserve redirecting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
self.stdoutand our own documentation, the following changes were made.sys.stdout.sys.stdout.print()within a pyscript now writes toself.stdout. Callingself.poutput()within a pyscript is still preferred, but that may not always be possible.