Skip to content

Conversation

@clach04
Copy link
Contributor

@clach04 clach04 commented Feb 8, 2025

No description provided.

Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akx akx enabled auto-merge (squash) March 4, 2025 13:10
@codecov
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.68%. Comparing base (0596065) to head (97db34d).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1189   +/-   ##
=======================================
  Coverage   91.68%   91.68%           
=======================================
  Files          27       27           
  Lines        4691     4691           
=======================================
  Hits         4301     4301           
  Misses        390      390           
Flag Coverage Δ
macos-14-3.10 90.72% <ø> (ø)
macos-14-3.11 90.66% <ø> (ø)
macos-14-3.12 90.87% <ø> (ø)
macos-14-3.13 ?
macos-14-3.8 ?
macos-14-3.9 90.65% <ø> (ø)
macos-14-pypy3.10 ?
ubuntu-24.04-3.10 90.74% <ø> (ø)
ubuntu-24.04-3.11 90.68% <ø> (ø)
ubuntu-24.04-3.12 90.89% <ø> (ø)
ubuntu-24.04-3.13 90.89% <ø> (ø)
ubuntu-24.04-3.8 90.61% <ø> (ø)
ubuntu-24.04-3.9 90.67% <ø> (ø)
ubuntu-24.04-pypy3.10 ?
windows-2022-3.10 90.73% <ø> (ø)
windows-2022-3.11 ?
windows-2022-3.12 ?
windows-2022-3.13 ?
windows-2022-3.8 ?
windows-2022-3.9 ?
windows-2022-pypy3.10 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomasr8
Copy link
Member

tomasr8 commented Mar 4, 2025

The pypy workflow is failing for some reason:

test_setuptools_commands

subprocess.CalledProcessError: Command '['/home/runner/work/babel/babel/.tox/py/bin/python', 'setup.py', 'init_catalog', '-i', '/dev/null', '-l', 'fi', '-d', 'inited']' returned non-zero exit status 1.

@akx
Copy link
Member

akx commented Mar 5, 2025

The pypy workflow is failing for some reason:

@tomasr8 Yeah, that's weird – it doesn't happen locally for me on that version of PyPy. #1197 works around that.

@akx akx disabled auto-merge March 5, 2025 07:16
@akx akx merged commit 755b52a into python-babel:master Mar 5, 2025
16 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants