Skip to content

Conversation

@tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Feb 3, 2025

I think it's better to centralize the tool configs in one file rather than have it scattered across multiple files. What do you think?

@codecov
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.68%. Comparing base (27e7303) to head (a83cf23).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1187   +/-   ##
=======================================
  Coverage   91.68%   91.68%           
=======================================
  Files          27       27           
  Lines        4689     4689           
=======================================
  Hits         4299     4299           
  Misses        390      390           
Flag Coverage Δ
macos-14-3.10 90.72% <ø> (ø)
macos-14-3.11 90.65% <ø> (ø)
macos-14-3.12 90.87% <ø> (ø)
macos-14-3.13 90.87% <ø> (ø)
macos-14-3.8 90.58% <ø> (ø)
macos-14-3.9 90.65% <ø> (ø)
macos-14-pypy3.10 90.72% <ø> (ø)
ubuntu-24.04-3.10 90.74% <ø> (ø)
ubuntu-24.04-3.11 90.68% <ø> (ø)
ubuntu-24.04-3.12 90.89% <ø> (ø)
ubuntu-24.04-3.13 90.89% <ø> (ø)
ubuntu-24.04-3.8 90.61% <ø> (ø)
ubuntu-24.04-3.9 90.67% <ø> (ø)
ubuntu-24.04-pypy3.10 90.74% <ø> (ø)
windows-2022-3.10 90.73% <ø> (ø)
windows-2022-3.11 90.67% <ø> (ø)
windows-2022-3.12 90.88% <ø> (ø)
windows-2022-3.13 90.88% <ø> (ø)
windows-2022-3.8 90.70% <ø> (ø)
windows-2022-3.9 90.66% <ø> (ø)
windows-2022-pypy3.10 90.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm also planning on switching builds to Hatch/Hatchling at some point (which will also take care of #850), so setup.cfg will be absolutely gone at that point.

@akx akx merged commit 0596065 into python-babel:master Feb 5, 2025
26 checks passed
@tomasr8
Copy link
Member Author

tomasr8 commented Feb 5, 2025

Awesome! We also use Hatch in our team and it's been working great so far

@tomasr8 tomasr8 deleted the pytest-ini branch February 5, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants