Repository navigation
Conversation
Signed-off-by: Casper Verbuyst <casperverbuyst@gmail.com>
Merging this PR will not alter performance1 note
Comparing Footnotes |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With stringified dataclass annotations (including
from __future__ import annotations), convertertype_overridesare looked up using strings such as"int"instead of the resolved types. For example,Converter(type_overrides={int: override(omit_if_default=True)})exports a default-valuedretries: int = 3field instead of omitting it. A rename override is also ignored when loading data, so the configured input key fails with a missing-field error. Eager annotations and attrs classes already work.Use the existing
adapted_fields()helper before selecting type overrides in both generated dict-hook entry points. It resolves dataclass annotations and retains the existing handling of attrs classes and generic origins. Add regression coverage for default omission, non-default values, renaming in both directions, both validation modes, and eager-annotation controls. Include a history entry.Validation on Windows:
Other operating systems and the remaining Python versions have not been tested locally. Upstream CI has not run.