Repository navigation
fix: preserve explicitly declared slots - #1648
Open
Samuel-Hills wants to merge 4 commits into
Open
Samuel-Hills wants to merge 4 commits into
Samuel-Hills wants to merge 4 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
attrscurrently drops slots declared directly on a slotted attrs-decorated class when it creates the replacement class. As a result, assigning to one of those declared slots raises aTypeError.This change preserves explicitly declared slots while retaining attrs-managed fields. It also adds a regression test and changelog entry.
Fixes #1637.
Validation
1406 passed, 6 skipped, 1 xfailedgit diff --check: passedPull Request Checklist
mainbranch.typing_tests/baseline.pyor, if necessary,typing_tests/mypy.py.attr/__init__.pyi, they've also been re-imported inattrs/__init__.pyi.docs/api.rstby hand.@attr.s()and@attrs.define()have to be added by hand too.changelog.d.