Skip to content

Fix generated __init__ forward-ref annotations under get_annotations / 3.14 #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MohammedAnasNathani wants to merge 4 commits into
base: main
Choose a base branch
from
+459 −48
Open

Fix generated __init__ forward-ref annotations under get_annotations / 3.14 #1598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8e9cfaf
Fix generated __init__ forward-ref annotations (#1596)
MohammedAnasNathani Jul 30, 2026
1c57965
Fix 3.14 init annotate fallback and getsource indent
MohammedAnasNathani Jul 30, 2026
a71d25a
Cover 3.14 init annotate STRING path and source rebind
MohammedAnasNathani Jul 30, 2026
0c6bf4f
Inline init annotate STRING static fallback for full coverage
MohammedAnasNathani Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog.d/1596.change.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Generated ``__init__`` methods now resolve late forward references the same way as hand-written constructors.

Previously, *attrs* snapshotted the defining module's globals when building ``__init__``, so names defined *after* the class body were missing from ``__init__.__globals__``.
On Python 3.14+, annotations are now attached via a PEP 649 ``__annotate__`` that re-reads live class annotations instead of a static dict of stale ``ForwardRef`` objects, and slot classes rewrite ``__annotate__`` closure cells to the final class.
Loading