Handle non-string error values in error responses - #172
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
+ Coverage 96.33% 98.31% +1.97%
==========================================
Files 7 7
Lines 1147 1304 +157
Branches 129 135 +6
==========================================
+ Hits 1105 1282 +177
+ Misses 25 12 -13
+ Partials 17 10 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RazerM
force-pushed
the
feature/error-message
branch
4 times, most recently
from
August 23, 2026 13:45
baefb59 to
85a08fb
Compare
Only set the Space-Track error message from the JSON 'error' value when it is a string; anything else falls back to showing the raw response body. A truthy non-string value previously raised TypeError from the message concatenation instead of the intended HTTPStatusError, so callers catching HTTPStatusError missed the failure. No such response has been observed from Space-Track; this is defensive hardening of the error reporting path.
RazerM
force-pushed
the
feature/error-message
branch
from
August 23, 2026 14:09
85a08fb to
18ab5c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only set the Space-Track error message from the JSON 'error' value when
it is a string; anything else falls back to showing the raw response
body. A truthy non-string value previously raised TypeError from the
message concatenation instead of the intended HTTPStatusError, so
callers catching HTTPStatusError missed the failure. No such response
has been observed from Space-Track; this is defensive hardening of the
error reporting path.