Conversation
psf-chronographer
Bot
added
the
bot:chronographer:provided
4 tasks
RonnyPfannschmidt
approved these changes
Sep 16, 2026
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
Member
There was a problem hiding this comment.
looks good, please ensure the ai attribution
Author
|
@RonnyPfannschmidt thanks for reviewing! added the AI attribution to the PR description. |
Member
|
thanks - for future reference - depending on the attribution policies and ai policies of a project it tends to be a good idea to pick where to add coAuthored/AIAssisted trailers or not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9924.
Doctests within a module share a runner. When an example exits early, its comparison flags can remain changed and affect a later docstring. This can cause false passes or false failures, depending on which option was enabled or disabled.
Save the incoming flags before running each doctest and restore them in
finally. This keeps an early exit from changing the next docstring's comparison settings.The 16 regression cases exercise
NUMBERandELLIPSIS, output mismatches, unexpected exceptions, skips and xfails. They also check both continue-on-failure modes. Before the fix, 10 cases fail and six compatibility checks pass; afterward, all 16 pass.Checks completed on macOS:
tox -e py313 -- -q): 4,618 passed, 51 skipped, 15 xfailed and 5 xpassed.tox -e py312 -- testing/test_doctest.py -q): 160 passed and 1 xfailed.tox -e linting): passed.Implemented and tested with the help from Codex.