bugfix #13224: hide progress dots in --quiet mode

[steinsag]

closes #13224: do not show progress dots in --quiet mode

[RonnyPfannschmidt]

-qq or -qqq should trigger this, just quiet should not

[nicoddemus]

-qq or -qqq should trigger this, just quiet should not

I agree, but let's settle on -qq then.

Besides this, we also need an integration test to ensure it works and does not regress in the future.

[steinsag]

-qq or -qqq should trigger this, just quiet should not

I agree, but let's settle on -qq then.

Besides this, we also need an integration test to ensure it works and does not regress in the future.

@nicoddemus

What would be the long version of -qq? --quiet --quiet?

Can you give me pointers how to write an integration test like pointing me at an example?

[indoor47]

Sorry, this went a bit out of hand, won't happen again. Cheers, D.

[steinsag]

ping @nicoddemus & @RonnyPfannschmidt

What would be the long version of -qq? --quiet --quiet?

Can you give me pointers how to write an integration test like pointing me at an example?

[RonnyPfannschmidt]

Q is the short option for quiet

Repeating works the same with long versions

For sanity i recommend testing only with short options

Argparse internally manages the rest

[nicoddemus]

To complement @RonnyPfannschmidt's answer:

Argument parsing already handles -qq, no need to change anything. When -qq is given, config.getoption("verbose") returns -2.

The integration test should:

• Use pytester (see examples in the test suite)
• Execute a small test suite with a few tests: most of them might all contain pass and not really do anything, except at one of them should fail.
• Check that nothing is output except for the errors.