Repository navigation
Fix hooks surviving historic replay cancellation - #811
Open
tridev-tej wants to merge 3 commits into
Open
tridev-tej wants to merge 3 commits into
tridev-tej wants to merge 3 commits into
Conversation
Muguett-DBY
approved these changes
Oct 29, 2026
Muguett-DBY
left a comment
There was a problem hiding this comment.
I checked d63d7491 on Windows with CPython 3.12.14.
uv run pytest: 260 passed, with pytest plugin autoload disabled.- I compared the base and this head across eight cases: unregistering or blocking during a historic implementation or its result callback, with and without a replacement registered under the same name. The base leaves the old historic and ordinary hook implementations active; this head removes them while retaining the unrelated plugin and, where applicable, the replacement.
No issue found in that scope. I haven't independently tested other Python versions or platforms. Codex helped with the source review and checks.
Author
|
@Pierre-Sassoulas any further feedback on this, or is it good to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugins unregistered or blocked during historic replay could leave hooks active.
Stop the cancelled registration before installing more hooks, while preserving replay order and nested replacements.