Skip to content

Fix subset_hook_caller failing to exclude plugins using specname #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bysiber wants to merge 1 commit into from
+4 −1
Closed

Fix subset_hook_caller failing to exclude plugins using specname #649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/pluggy/_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,10 @@ def subset_hook_caller(
method which manages calls to all registered plugins except the ones
from remove_plugins."""
orig: HookCaller = getattr(self.hook, name)
plugins_to_remove = {plug for plug in remove_plugins if hasattr(plug, name)}
registered_plugins = {impl.plugin for impl in orig._hookimpls}
plugins_to_remove = {
plug for plug in remove_plugins if plug in registered_plugins
}
if plugins_to_remove:
return _SubsetHookCaller(orig, plugins_to_remove)
return orig
Expand Down