Fix broadcast check on IncSubtensor with boolean masks#2303
Merged
ricardoV94 merged 1 commit intoJul 19, 2026
Conversation
ricardoV94
commented
Jul 19, 2026
ricardoV94
force-pushed
the
fix_runtime_broadcasting_on_bool
branch
from
July 19, 2026 12:36
187fb88 to
140b827
Compare
ricardoV94
force-pushed
the
fix_runtime_broadcasting_on_bool
branch
from
July 19, 2026 12:53
140b827 to
e7687fb
Compare
jessegrabowski
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we replaced AdvancedSetSubtensor1 -> AdvacedSubtensor1 we moved the runtime check on the first axis (not yet full runtime check), but we didn't gate correctly on whether that first vector index is a integer or a bool, for bool it's not the shape that matters it's the entries == 1 (aka sum()).
For now I keep just the old check conditions. We'll extend the runtime broadcasting to be exhaustive but I want to delay more breaking changes for now