Let each rule name the state it allocates - #151
Open
jessegrabowski wants to merge 1 commit into
Open
Conversation
The state-name guard already told callers to give one of two colliding rules a namespace of its own, and no rule accepted one.
jessegrabowski
force-pushed
the
per-group-rules
branch
from
September 2, 2026 09:26
cd11ae5 to
af76833
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two rules of the same kind in one step both name their step counter after the rule, so
compile_trainrefuses the graph. The guard that catches it tells you to give one anamespaceof its own. No rule accepted one. Every rule takes one now.Closes #132
📚 Documentation preview 📚: https://pytensor-ml--151.org.readthedocs.build/en/151/