Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 90.16% 90.40% +0.23%
==========================================
Files 24 25 +1
Lines 1922 2000 +78
==========================================
+ Hits 1733 1808 +75
- Misses 189 192 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The whitening cutoff can collapse valid low-scale covariance matrices to a zero alignment.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds CORAL domain adaptation with public exports, documentation, and tests.
Changes:
- Implements covariance-based source-to-target alignment.
- Exposes CORAL through transformer and embedding APIs.
- Adds validation, numerical, API, and documentation coverage.
File summaries
| File | Description |
|---|---|
kalelinear/transformer/_coral.py |
Implements CORAL. |
kalelinear/transformer/__init__.py |
Exports CORAL. |
kalelinear/embed.py |
Adds embedding API alias. |
tests/transformer/test_coral.py |
Tests CORAL behavior and validation. |
tests/test_public_api.py |
Verifies public exposure. |
README.md |
Documents feature and citation. |
TUTORIALS.md |
Adds usage example. |
docs/source/usage.rst |
Describes domain alignment behavior. |
docs/source/tutorial.rst |
Adds CORAL tutorial. |
docs/source/introduction.rst |
Lists CORAL among transformers. |
docs/source/api_transformers.rst |
Adds generated API documentation. |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "CORAL cannot compute a whitening transform; try a positive `lambda_`." | ||
| ) | ||
|
|
||
| tolerance = 10 * np.finfo(eigenvalues.dtype).eps * max(1.0, max_eigenvalue) * eigenvalues.shape[0] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add CORAL (CORrelation ALignment) domain adaptation
Status
Work in progress
Types of changes
docsupdated.