Update numpy to 2.5.1#529
Conversation
📝 WalkthroughWalkthroughThe project updates NumPy pins to 2.5.1, adds sparse 0.19.0 to environment configurations, declares Python 3.14 support, and revises neighbor warning-count assertions. ChangesDependency and neighbor test updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
|
Even the latest numba still requires numpy < 2.5: |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/test_neighbors.py (1)
504-505: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAssert warning causes per operation, not a cumulative count.
Because
wis shared,len(w) == 4only checks the total from both calls and can pass even if.distancesemits a different number of warnings. The random position also makes exact counts geometry-sensitive. Capture each operation separately and assert the expected warning messages.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/test_neighbors.py` around lines 504 - 505, Update the test around the two get_neighborhood calls to capture warnings separately for each operation instead of using the shared w list. Assert each call’s expected warning messages and counts independently, while replacing the random position with a deterministic input so the assertions are not geometry-sensitive.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/test_neighbors.py`:
- Around line 504-505: Update the test around the two get_neighborhood calls to
capture warnings separately for each operation instead of using the shared w
list. Assert each call’s expected warning messages and counts independently,
while replacing the random position with a deterministic input so the assertions
are not geometry-sensitive.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4aa77766-b22b-47cd-9b25-ef19d14afdd6
📒 Files selected for processing (6)
.ci_support/environment-docs.yml.ci_support/environment-mini.yml.ci_support/environment.ymlbinder/environment.ymlpyproject.tomltests/test_neighbors.py
Summary by CodeRabbit
New Features
Compatibility
Bug Fixes