Skip to content

[Fix] Write spawner file to executorlib cache#1025

Merged
jan-janssen merged 1 commit into
mainfrom
spawner_cache
Jun 19, 2026
Merged

[Fix] Write spawner file to executorlib cache#1025
jan-janssen merged 1 commit into
mainfrom
spawner_cache

Conversation

@jan-janssen

@jan-janssen jan-janssen commented Jun 19, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Improved working directory organization for spawned processes. Temporary working directories are now created under a dedicated executorlib_cache folder, providing better file organization and preventing clutter in the system root.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9ad9d799-dd8b-4e88-9e52-3fc3ace3ca60

📥 Commits

Reviewing files that changed from the base of the PR and between 4848ef9 and ee25914.

📒 Files selected for processing (1)
  • src/executorlib/task_scheduler/interactive/spawner_pysqa.py

📝 Walkthrough

Walkthrough

In PysqaSpawner._start_process_helper, the fallback working_directory when self._cwd is None is changed from os.path.abspath(hash) (which produced /<hash>) to a path joining an absolute executorlib_cache directory with the computed hash.

Changes

Working Directory Fallback Fix

Layer / File(s) Summary
Fix fallback working directory path construction
src/executorlib/task_scheduler/interactive/spawner_pysqa.py
Changes the default working_directory from the hash alone (yielding an incorrect absolute path) to executorlib_cache/<hash> when no cwd is configured.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 A hash stood alone at the root of the tree,
lost in the filesystem, nowhere to be!
Now tucked in a cache with a warm cozy name,
executorlib_cache — it knows whence it came.
Hop hop, little path, you're home! 🥕

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Write spawner file to executorlib cache' directly reflects the main change: updating the default working_directory path to use executorlib_cache instead of the root directory.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch spawner_cache

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.24%. Comparing base (640e440) to head (ee25914).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1025   +/-   ##
=======================================
  Coverage   94.24%   94.24%           
=======================================
  Files          39       39           
  Lines        2119     2119           
=======================================
  Hits         1997     1997           
  Misses        122      122           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jan-janssen jan-janssen merged commit 75a8c56 into main Jun 19, 2026
67 of 69 checks passed
@jan-janssen jan-janssen deleted the spawner_cache branch June 19, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant